Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendor dependencies for endpointslice controller #331

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Sep 26, 2024

required for #331

go get 'k8s.io/endpointslice/util@v0.28' 'k8s.io/apiserver@v0.28' 'k8s.io/cloud-provider@v0.28'
go mod tidy
go mod vendor

Signed-off-by: Andrei Kvapil kvapss@gmail.com

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 26, 2024
@kvaps
Copy link
Member Author

kvaps commented Sep 26, 2024

/assign @qinqon

@qinqon
Copy link
Contributor

qinqon commented Sep 26, 2024

/retest

@kvaps kvaps force-pushed the endpointslice-controller-vendor branch 2 times, most recently from 07b4106 to dd6396d Compare September 26, 2024 17:52
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps kvaps force-pushed the endpointslice-controller-vendor branch from dd6396d to 5a1e0ab Compare September 26, 2024 17:58
@kvaps
Copy link
Member Author

kvaps commented Sep 26, 2024

I don't know why test is failing, locally it is built ok:

[+] Building 6.2s (15/15) FINISHED                                                                                                                                               docker:amd64
 => [internal] load build definition from Dockerfile                                                                                                                                     0.9s
 => => transferring dockerfile: 605B                                                                                                                                                     0.1s
 => [internal] load metadata for registry.access.redhat.com/ubi9/ubi-micro:latest                                                                                                        0.7s
 => [internal] load metadata for docker.io/library/golang:1.20.6                                                                                                                         1.6s
 => [internal] load .dockerignore                                                                                                                                                        0.3s
 => => transferring context: 2B                                                                                                                                                          0.1s
 => [stage-1 1/2] FROM registry.access.redhat.com/ubi9/ubi-micro:latest@sha256:7f376b75faf8ea546f28f8529c37d24adcde33dca4103f4897ae19a43d58192b                                          0.0s
 => [builder 1/7] FROM docker.io/library/golang:1.20.6@sha256:010a0ffe47398a3646993df44906c065c526eabf309d01fb0cbc9a5696024a60                                                           0.0s
 => [internal] load build context                                                                                                                                                        1.3s
 => => transferring context: 591.91kB                                                                                                                                                    1.0s
 => CACHED [builder 2/7] WORKDIR /go/src/kubevirt.io/cloud-provider-kubevirt                                                                                                             0.0s
 => CACHED [builder 3/7] COPY go.* ./                                                                                                                                                    0.0s
 => CACHED [builder 4/7] COPY pkg/ pkg/                                                                                                                                                  0.0s
 => CACHED [builder 5/7] COPY cmd/ cmd/                                                                                                                                                  0.0s
 => CACHED [builder 6/7] COPY vendor/ vendor/                                                                                                                                            0.0s
 => CACHED [builder 7/7] RUN CGO_ENABLED=0 GOOS=linux go build -mod=vendor -ldflags="-s -w" -o bin/kubevirt-cloud-controller-manager ./cmd/kubevirt-cloud-controller-manager             0.0s
 => CACHED [stage-1 2/2] COPY --from=builder /go/src/kubevirt.io/cloud-provider-kubevirt/bin/kubevirt-cloud-controller-manager /bin/kubevirt-cloud-controller-manager                    0.0s
 => exporting to image                                                                                                                                                                   0.3s
 => => exporting layers                                                                                                                                                                  0.0s
 => => writing image sha256:81be6df64c5480450a78eb7c9dd095ff4073b18d88325aa24ffc3992ee5cc52a                                                                                             0.1s
 => => naming to 127.0.0.1:40349/kubevirt-cloud-controller-manager:main                                                                                                                  0.1s

 1 warning found (use --debug to expand):
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 1)

@kvaps
Copy link
Member Author

kvaps commented Sep 26, 2024

/test pull-kubevirt-cloud-provider-kubevirt-e2e

@qinqon
Copy link
Contributor

qinqon commented Sep 28, 2024

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2024
@kvaps
Copy link
Member Author

kvaps commented Oct 2, 2024

/test pull-kubevirt-cloud-provider-kubevirt-e2e

@qinqon
Copy link
Contributor

qinqon commented Oct 7, 2024

/retest

Issue was fixed.

@kubevirt-bot kubevirt-bot merged commit a749c7d into kubevirt:main Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants