-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add s390x Artifacts #182
base: main
Are you sure you want to change the base?
Add s390x Artifacts #182
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @Rurouni-Jiaxin. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Rurouni-Jiaxin Thanks for your PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for your contribution!
You are right that the unit tests are mainly focused on parsing data returned from the mirrors. Nonetheless, can you please add unit tests for s390x
in the artifacts you touched? (fedora
, centosstream
and ubuntu
). Opensuse does not ship cloud images for s390x
, so it is okay to leave it out.
Are you going to add s390x
preferences to common-instancetypes soon? Otherwise I would like to ask you to remove the instancetypes/preferences from the images env variables for now.
We don't have automated testing for aarch64
artifacts yet but we're looking to add that in the future. Would you be able to provide resources to automate the testing of s390x
artifacts?
Last question: Did you verify the newly created containerdisks are able to boot in your local environment?
Regarding s390x resources, I assume by looking at the nodeSelector in these ProwJobs, that bare metal servers are required. Such resources would be available on s390x, but it will take time. |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Still testing on my local s390x environment |
/hold |
What this PR does / why we need it:
I create this PR as part of the bigger effort to enable KubeVirt on s390x, a.k.a IBM Z ( please refer to : kubevirt/kubevirt#10490 ). It appears that https://github.com/kubevirt/common-instancetypes/ depends on
containerdisks
.Therefore I added "s390x" entries to existing Feodora, CentOS Stream and Ubuntu Artifact / registries.
I have not added any tests to either
artifacts/fedora/fedora_test.go
,artifacts/centosstream/centos-stream_test.go
, orartifacts/ubuntu/ubuntu_test.go
, because the tests appears to only verify the parsing function.TO DO:
Discuss whether other Linux distros, e.g. OpenSUSE is needed for s390x.
Special notes for your reviewer:
Release note: