Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing CNAO's CR manifest and bump kubevirt #33

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Add missing CNAO's CR manifest and bump kubevirt #33

merged 2 commits into from
Dec 1, 2022

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Nov 29, 2022 •
edited
Loading

Add missing CNAO's CR manifest, in order to allow deploying CNAO and it's CR.
Bump kubevirt so we can create VMs on k8s-1.25 as well.

None

@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 29, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added size/XS release-note-none Denotes a PR that doesn't merit a release note. size/S and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS labels Nov 29, 2022
@oshoval oshoval changed the title cnao: Add missing CR manifest cnao/kubevirt: Add missing CR manifest and bump kubevirt Nov 29, 2022
@oshoval oshoval marked this pull request as ready for review November 29, 2022 14:12
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2022
@oshoval oshoval changed the title cnao/kubevirt: Add missing CR manifest and bump kubevirt Add missing CNAO's CR manifest and bump kubevirt Nov 29, 2022
@oshoval
kubevirt: Bump kubevirt
d4bddd5 
Without it, create vm failed because kvm was missing.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Collaborator Author

oshoval commented Nov 30, 2022 •
edited
Loading

For some reason the e2e status is not reported back
also the DCO didnt work

pushing empty changes to fix it

@oshoval
cnao: Add missing CR manifest
2b3ae96 
Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@AlonaKaplan AlonaKaplan merged commit 1b1ef3e into kubevirt:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonaKaplan AlonaKaplan AlonaKaplan approved these changes

Assignees

@AlonaKaplan AlonaKaplan

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @kubevirt-bot @AlonaKaplan