Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git actions: Add PR template #35

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Nov 29, 2022

Signed-off-by: Or Shoval oshoval@redhat.com

None

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 29, 2022
@dteplits
Copy link
Contributor

dteplits commented Dec 1, 2022

/approve

@dteplits
Copy link
Contributor

dteplits commented Dec 1, 2022

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 5, 2022

Addressed comments

@AlonaKaplan
Copy link
Member

/approve

@AlonaKaplan
Copy link
Member

@oshoval Side note, please make sure the release note are actually collected and added to the release.

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 5, 2022

@oshoval Side note, please make sure the release note are actually collected and added to the release.

If there is no automation for it, i can remove it for now, because i can't create automation at the near future
unless we have examples to be based on

@AlonaKaplan
Copy link
Member

AlonaKaplan commented Dec 5, 2022

@oshoval Side note, please make sure the release note are actually collected and added to the release.

If there is no automation for it, i can remove it for now, because i can't create automation at the near future unless we have examples to be based on

Let's start from checking if it is magically working. If not, let's remove it from the template and from prow.

@AlonaKaplan
Copy link
Member

/approve cancel
let's first verify the release notes are working.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@oshoval
Copy link
Collaborator Author

oshoval commented Dec 5, 2022

Rebase

@oshoval
Copy link
Collaborator Author

oshoval commented Dec 5, 2022

It seems we need to add something like this (thanks Petr)
https://github.com/nmstate/kubernetes-nmstate/blob/main/hack/render-release-notes.sh#L14

I prefer to not dive into it at the moment, first to close other stuff
Can we merge the PR as is, and later add the functionality please ?
The PR doesn't introduce a regression as is
I will open a Jira ticket for it

@AlonaKaplan
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan, dteplits

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@kubevirt-bot kubevirt-bot merged commit bb72278 into kubevirt:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants