-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git actions: Add PR template #35
Conversation
/approve |
/lgtm |
Addressed comments |
/approve |
@oshoval Side note, please make sure the release note are actually collected and added to the release. |
If there is no automation for it, i can remove it for now, because i can't create automation at the near future |
Let's start from checking if it is magically working. If not, let's remove it from the template and from prow. |
/approve cancel |
Signed-off-by: Or Shoval <oshoval@redhat.com>
Rebase |
It seems we need to add something like this (thanks Petr) I prefer to not dive into it at the moment, first to close other stuff |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan, dteplits The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Or Shoval oshoval@redhat.com