readme: Update readme file #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
kubevirt-bot
added
the
do-not-merge/work-in-progress
oshoval
force-pushed
the
readme
branch
3 times, most recently
from
994d1dc
to
c5ad2ed
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
kubevirt-bot
added
the
do-not-merge/work-in-progress
oshoval
changed the title
dteplits
reviewed
Dec 4, 2022
dteplits
reviewed
Dec 4, 2022
oshoval
force-pushed
the
readme
branch
3 times, most recently
from
925577e
to
e9ef1e1
Compare
kubevirt-bot
removed
the
do-not-merge/work-in-progress
oshoval
force-pushed
the
readme
branch
2 times, most recently
from
29ed889
to
a5e603e
Compare
AlonaKaplan
reviewed
Dec 5, 2022
|
Rebase |
|
Addressed comments need to fix whitespace check to ignore it |
|
Fixed whitespace to ignore markdown files |
AlonaKaplan
reviewed
Dec 12, 2022
|
Addressed comments (beside https://github.com/kubevirt/kubesecondarydns/pull/37/files#r1045608648 yet) |
|
Updated manifest, also updated the image to be the same as the one we have on the test EDIT fixing the commits |
oshoval
force-pushed
the
readme
branch
2 times, most recently
from
803bd96
to
f49c228
Compare
Line that ends with two spaces in markdown file is used in order to add a line break. Hence let whitespace check ignore markdown files. Signed-off-by: Or Shoval <oshoval@redhat.com>
Includes: Prerequisites. Info about how to deploy the plugin. Parameters. Info about how to develop the plugin. Basic manifests example. High level design section. Signed-off-by: Or Shoval <oshoval@redhat.com>
|
Rebase |
oshoval
requested review from
AlonaKaplan
and removed request for
dteplits and
AlonaKaplan
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
Beside that:
Ignore whitespace check on markdown files
(double space at the end means new line).