Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest, psa: Use qemu UID #53

Merged
merged 1 commit into from
Jan 3, 2023
Merged

manifest, psa: Use qemu UID #53

merged 1 commit into from
Jan 3, 2023

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Jan 3, 2023

What this PR does / why we need it:
This way we can deloy it on CRC as well
(tried with HCO on top of CRC)

Special notes for your reviewer:

Release note:

None

This way we can deloy it on CRC as well.

Signed-off-by: Or Shoval <oshoval@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 3, 2023
@AlonaKaplan
Copy link
Member

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@kubevirt-bot kubevirt-bot merged commit 57d3354 into kubevirt:main Jan 3, 2023
@oshoval
Copy link
Collaborator Author

oshoval commented Jan 3, 2023

I checked it wrong, it doesn't fix the problem

@oshoval
Copy link
Collaborator Author

oshoval commented Jan 12, 2023

@AlonaKaplan
Should we revert this one back to 1000 so it will be like CNAO right ?
(nicer even if not mandatory, unless 107 is better)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants