Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding cpu and memory requests to status-monitor container and remove limit from the coredns container #54

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Adding cpu and memory requests to status-monitor container and remove limit from the coredns container #54

merged 2 commits into from
Jan 3, 2023

Conversation

AlonaKaplan
Copy link
Member

@AlonaKaplan AlonaKaplan commented Jan 3, 2023 •
edited
Loading

What this PR does / why we need it:
Adding resources.requests cpu and memory to status-monitor container.
Remove the resources.limit.memory from the coredns container.

Special notes for your reviewer:

Release note:

NONE

@AlonaKaplan
Adding resources.requests cpu and memory to status-monitor container
1783cd5 
Signed-off-by: Alona Paz <alkaplan@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 3, 2023
oshoval
oshoval approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@AlonaKaplan
coredns: remove the resource.limit.memory from the coredns container
fa8b544 
Signed-off-by: Alona Paz <alkaplan@redhat.com>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@AlonaKaplan AlonaKaplan changed the title Adding resources.requests cpu and memory to status-monitor container Adding resources.requests cpu and memory to status-monitor container and remove limit from the coredns container Jan 3, 2023
@AlonaKaplan AlonaKaplan changed the title Adding resources.requests cpu and memory to status-monitor container and remove limit from the coredns container Adding cpu and memory requests to status-monitor container and remove limit from the coredns container Jan 3, 2023
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@AlonaKaplan
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 3, 2023
@kubevirt-bot kubevirt-bot merged commit e22050c into kubevirt:main Jan 3, 2023
@oshoval
Copy link
Collaborator

oshoval commented Jan 12, 2023

Can you issue please a new tag ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oshoval oshoval oshoval approved these changes

@dteplits dteplits Awaiting requested review from dteplits

Assignees

@oshoval oshoval

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlonaKaplan @kubevirt-bot @oshoval