Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove release-note from the PR template #55

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

AlonaKaplan
Copy link
Member

@AlonaKaplan AlonaKaplan commented Jan 12, 2023

What this PR does / why we need it:
The repository has a github action that generates the changelog of the release with the PR title.
It should be enough.

Special notes for your reviewer:
The PR depends on kubevirt/project-infra#2548

The repo has a github action that generate the changelog of the release
with the PR title. It should be enough.

Signed-off-by: Alona Paz <alkaplan@redhat.com>
@kubevirt-bot
Copy link
Contributor

@AlonaKaplan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Jan 12, 2023
@AlonaKaplan
Copy link
Member Author

Closing temporary till the project-infra is merged.

@oshoval
Copy link
Collaborator

oshoval commented Jan 12, 2023

This template just ask the user to add the release notes
nothing beside

Project infra already has the plugin
Just the github actions was / is missing

@AlonaKaplan AlonaKaplan reopened this Jan 12, 2023
@AlonaKaplan
Copy link
Member Author

This template just ask the user to add the release notes nothing beside

Project infra already has the plugin Just the github actions was / is missing

As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR.
It is more than enough.

I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log.
cnao for example are using k8s.io/release/cmd/release-notes binary to gather the notes from the PRs and generate the change log. We can use it as well and append it to our change log, but I find it redundant. The changelog generated by the github action is good enough.

@oshoval
Copy link
Collaborator

oshoval commented Jan 12, 2023

This template just ask the user to add the release notes nothing beside
Project infra already has the plugin Just the github actions was / is missing

As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR. It is more than enough.

I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log. cnao for example are using k8s.io/release/cmd/release-notes binary to gather the notes from the PRs and generate the change log. We can use it as well and append it to our change log, but I find it redundant. The changelog generated by the github action is good enough.

It collects the PR desc,
original plan was indeed to add as CNAO does
It might be less informative on special cases, but we can live without it for now.

@AlonaKaplan
Copy link
Member Author

This template just ask the user to add the release notes nothing beside
Project infra already has the plugin Just the github actions was / is missing

As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR. It is more than enough.
I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log. cnao for example are using k8s.io/release/cmd/release-notes binary to gather the notes from the PRs and generate the change log. We can use it as well and append it to our change log, but I find it redundant. The changelog generated by the github action is good enough.

It collects the PR desc, original plan was indeed to add as CNAO does It might be less informative on special cases, but we can live without it for now.

I discussed it will @qinqon and even in cnao they plan to stop using this binary. The changelog generated by the current github action is more than enough to this repo.

Copy link
Collaborator

@oshoval oshoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wait for the infra, as it wont break nothing
Thanks

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@AlonaKaplan
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlonaKaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@AlonaKaplan AlonaKaplan removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jan 12, 2023
@kubevirt-bot kubevirt-bot merged commit 4ac545a into kubevirt:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants