-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove release-note from the PR template #55
Conversation
The repo has a github action that generate the changelog of the release with the PR title. It should be enough. Signed-off-by: Alona Paz <alkaplan@redhat.com>
@AlonaKaplan: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing temporary till the project-infra is merged. |
This template just ask the user to add the release notes Project infra already has the plugin |
As the PR description says, the release github action already generate a releasen-note with out the need to manually add the text to each PR. I couldn't find a github action that collects the release-note from each PR and adds all those notes to the change-log. |
It collects the PR desc, |
I discussed it will @qinqon and even in cnao they plan to stop using this binary. The changelog generated by the current github action is more than enough to this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to wait for the infra, as it wont break nothing
Thanks
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlonaKaplan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The repository has a github action that generates the changelog of the release with the PR title.
It should be enough.
Special notes for your reviewer:
The PR depends on kubevirt/project-infra#2548