[release-v0.6] Test and env updates #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This label can be used to run tests with focus on tests we consider neccessary to test partner compatibility with kubevirt. To run the tests: make TEST_ARGS="--test-args=-ginkgo.label-filter=PartnerComp" test-functional Signed-off-by: Shelly Kagan <skagan@redhat.com>
This change allows the user to set env variable KVP_STORAGE_CLASS with the desired storage class one wants the tests applying yamls to run with. Adjust some tests to pass when using wffc SC Signed-off-by: Shelly Kagan <skagan@redhat.com>
The test wants to catch the dv in state importing but if the import is fast we can miss it. Insted we can check that a file that existed no longer exists after the backup. Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
Signed-off-by: Shelly Kagan <skagan@redhat.com>
Merged
kubevirt-bot
added
the
dco-signoff: yes
|
/lgtm @ShellyKa13 I assume we will want to do a new 0.6 tag/build when this merges? |
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mhenriks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@mhenriks I want to also fix the tests expecting number of backup items before the new tag |
|
/hold cancel |
kubevirt-bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #208
/assign ShellyKa13