Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable coveralls reporting due to service outage #2178

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Disable coveralls reporting due to service outage #2178

merged 1 commit into from
Jun 30, 2022

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Jun 30, 2022

We need to check the status page before we take this back in.

/cc @brianmcarey @xpivarc @enp0s3

@dhiller
Disable coveralls reporting due to service outage
294c307 
https://status.coveralls.io/

Signed-off-by: Daniel Hiller <dhiller@redhat.com>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Jun 30, 2022
xpivarc
xpivarc reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
We might want to disable them altogether as there is no chance they will succeed for a while.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2022
@dhiller
Copy link
Contributor Author

dhiller commented Jun 30, 2022

/lgtm We might want to disable them altogether as there is no chance they will succeed for a while.

As pointed out in the mail I think we should still call them, as as soon when the service is back online we will have data again. WDYT?

@dhiller
Copy link
Contributor Author

dhiller commented Jun 30, 2022

Additionally it looks like they just disabled routing to the backend service, so I think that we will do no harm.

brianmcarey
brianmcarey approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2022
@brianmcarey
Copy link
Member

brianmcarey commented Jun 30, 2022 •
edited
Loading

/hold - it looks like the status page is reporting that the unplanned maintenance has been completed? https://status.coveralls.io/

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@xpivarc
Copy link
Member

xpivarc commented Jun 30, 2022

/hold - it looks like the status page is reporting that the unplanned maintenance has been completed? https://status.coveralls.io/

/hold cancel
https://coveralls.io/ They have another planned outage for tonight.
/lgtm

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2022
@kubevirt-bot kubevirt-bot merged commit b8c6755 into kubevirt:main Jun 30, 2022
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubevirt-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-postsubmits.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml

In response to this:

We need to check the status page before we take this back in.

/cc @brianmcarey @xpivarc @enp0s3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@brianmcarey brianmcarey brianmcarey approved these changes

@enp0s3 enp0s3 Awaiting requested review from enp0s3

Assignees

@brianmcarey brianmcarey

@xpivarc xpivarc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dhiller @kubevirt-bot @brianmcarey @xpivarc