Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong link and typo #778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Davidffry
Copy link

What this PR does / why we need it: Change / Fix / Add feature for documentation

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): No Issue fix
Fixes #

Special notes for your reviewer: I think we need to change all the oc command in the documentation, to be more agnostic. If some specificities in Openshift, either create each time if necessary a dedicated chapter or push it outside the kubevirt.
Because you ask to try with the quickstart but we can't use the oc command.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Signed-off-by: David AUFFRAY <31964077+Davidffry@users.noreply.github.com>
@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Mar 25, 2024
@kubevirt-bot
Copy link
Contributor

Hi @Davidffry. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS labels Mar 25, 2024
@jean-edouard
Copy link
Contributor

Thanks @Davidffry
PR makes sense and special notes too. Any reason to keep this as a draft?
/approve

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@Davidffry Davidffry marked this pull request as ready for review March 25, 2024 15:57
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024
@Davidffry
Copy link
Author

Davidffry commented Mar 25, 2024

Thanks @Davidffry PR makes sense and special notes too. Any reason to keep this as a draft?

No really reason, but re-read I view, in the header, that there is a note with this "By deploying KubeVirt on top of OpenShift the user can benefit from the OpenShift Template functionality."

maybe change into kind : "Only on Openshift Cluster"

There is no Template CRD in Kubevirt/Kubernetes deployment. Only Openshift.

Copy link
Contributor

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Davidffry !
I have one suggestion to make it a bit easier to parse as having a parenthesis after the "like" makes it seems like the sentence has been cut short.
I see other annotation examples still have it (which we should change in a subsequent PR), but hopefully this makes this one a bit clearer.

@@ -237,7 +237,7 @@ the kubevirt services.

Here's a description of the kubevirt annotations. Unless otherwise
specified, the following keys are meant to be top-level entries of the
template metadata, like
template metadata, like (for Openshift console to display)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
template metadata, like (for Openshift console to display)
template metadata. For OpenShift console to display:

@kubevirt-bot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@fabiand
Copy link
Member

fabiand commented Jun 21, 2024

@Davidffry Thanks for the contribution!

Can you rebase and address Andrew's comment?

Thanks!

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@fabiand
Copy link
Member

fabiand commented Jun 21, 2024

/delgtm
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabiand, jean-edouard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabiand,jean-edouard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabiand
Copy link
Member

fabiand commented Jun 21, 2024

/remove-lgtm

Andrew, please lgtm once we are good

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 19, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants