-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operations, network: Declare network hotplug feature as GA #841
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Edward Haas <edwardh@redhat.com>
75e2c5d
to
cadfd4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @EdDev.
Unrelated to this PR - IMO it is unclear from the text that NIC hotplug/unplug is only applicable for secondary NICs.
/hold
Lets wait for kubevirt/kubevirt#13059 to be merged before merging this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
@EdDev Thank you!
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: enp0s3 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The network hotplug feature has been available since Kubevirt v1.1 as Alpha, followed in v1.3 as Beta.
There have been no changes in the API since and the feedback from users has been positive.
Therefore, the feature is declared GA towards v1.4.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: