docs: Add information about authentication #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
ksimon1
reviewed
Oct 16, 2023
ksimon1
reviewed
Oct 16, 2023
akrejcir
force-pushed
the
doc-authentication
branch
from
7e5a0ad
to
f668bb6
Compare
jcanocan
reviewed
Oct 16, 2023
docs/api.md
Outdated
Comment on lines
35
to
36
| Kubernetes supports two main ways of authenticating, token and TLS client certificates, and other ways can be added | ||
| using an authenticating proxy. More information can be found in the [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#authentication-strategies). |
There was a problem hiding this comment.
Suggested change
| Kubernetes supports two main ways of authenticating, token and TLS client certificates, and other ways can be added | |
| using an authenticating proxy. More information can be found in the [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#authentication-strategies). | |
| Kubernetes supports two main ways of authenticating, token and TLS client certificates. Nevertheless, other ways can be added | |
| using an authenticating proxy. More information can be found in the [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#authentication-strategies). |
There was a problem hiding this comment.
That doesn't sound right to me. Nevertheless has a different meaning.
There was a problem hiding this comment.
I agree, separating this into two sentences makes it easier to understand.
0xFelix
reviewed
Oct 17, 2023
docs/api.md
Outdated
Comment on lines
35
to
36
| Kubernetes supports two main ways of authenticating, token and TLS client certificates, and other ways can be added | ||
| using an authenticating proxy. More information can be found in the [documentation](https://kubernetes.io/docs/reference/access-authn-authz/authentication/#authentication-strategies). |
There was a problem hiding this comment.
I agree, separating this into two sentences makes it easier to understand.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
akrejcir
force-pushed
the
doc-authentication
branch
from
f668bb6
to
5a21295
Compare
|
Good job! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Added a short explanation of Kubernetes authentication method to API doc.