Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a Role that will be used by users #75

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Jan 5, 2024

What this PR does / why we need it:
The new Role token.kubevirt.io:generate will be installed in the cluster, and can be bound to user accounts to access the endpoint that generates tokens.

Which issue(s) this PR fixes:
Fixes #36

Release note:

Added role "token.kubevirt.io:generate" for users to access token generation endpoint.

This new Role "token.kubevirt.io:generate" will
be installed in the cluster and can be bound to user
accounts to give them access to the endpoint
that generates tokens.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 5, 2024
@akrejcir
Copy link
Collaborator Author

akrejcir commented Jan 5, 2024

/cc @ksimon1 @jcanocan

@ksimon1
Copy link
Member

ksimon1 commented Jan 5, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2024
@akrejcir
Copy link
Collaborator Author

akrejcir commented Jan 5, 2024

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrejcir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 5, 2024
@kubevirt-bot kubevirt-bot merged commit 5221624 into kubevirt:main Jan 5, 2024
5 checks passed
@akrejcir akrejcir deleted the add-generate-role branch March 5, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Role that can access the new API endpoint
3 participants