Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait namespace is actually deleted (#413) #422

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Conversation

kensipe
Copy link
Member

@kensipe kensipe commented Nov 14, 2022

Originally on #413 was merged and caused failures. We have issues with contributor PR being tested on circle ci. This is the same PR. The squashed commit was reverted and this PR is a cherry-pick of that commit

Co-authored-by: Erik Godding Boye egboye@gmail.com
Signed-off-by: Charles-Edouard Brétéché charles.edouard@nirmata.com

What this PR does / why we need it:

Fixes #

@chipzoller
Copy link

chipzoller commented Nov 18, 2022

How can we help here? Without this fix it's causing test failures on our side. See kyverno/kyverno#5413.

@eddycharly
Copy link
Contributor

@chipzoller im waiting for the CI PR to merge so that I can investigate better.

@eddycharly
Copy link
Contributor

This one #337
cc @kensipe

@eddycharly
Copy link
Contributor

I wonder if this happens because k8s components are not deployed in the cluster, therefore namespace finalizers are never processed.

@kensipe
Copy link
Member Author

kensipe commented Nov 28, 2022

yeah... the integration-tests are just against etcd and api-server (no controllers). We will need to look into a solution around that. The e2e tests should be against a kind cluster but don't appear to be... need to look into why on that as well. I really like this PR and will work to work it in.

Co-authored-by: Erik Godding Boye <egboye@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Signed-off-by: Ken Sipe <kensipe@gmail.com>
@kensipe
Copy link
Member Author

kensipe commented Dec 20, 2022

@eddycharly as suspected... when running against testenv, we can't delete namespaces and need to skip-delete. Testing all looked good. plan to merge after CI. Thanks for this great work!

@kensipe kensipe merged commit 049344a into main Dec 20, 2022
@kensipe kensipe deleted the ken/ns-delete2 branch December 20, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants