Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert support implementation for Node16/NodeNext #4487

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: revert support implementation for Node16/NodeNext #4487

merged 1 commit into from
Aug 1, 2024

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 31, 2024

Summary

See commit

Fixes #4468
Fixes #4473

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl force-pushed the fix/revert-support-node16-nodenext branch 3 times, most recently from ffa2ecb to a5a8f93 Compare July 31, 2024 19:28
@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10187014321

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 95.281%
Totals Coverage Status
Change from base Build 10183631199: 0.03%
Covered Lines: 4759
Relevant Lines: 4937
💛 - Coveralls

@ahnpnl ahnpnl force-pushed the fix/revert-support-node16-nodenext branch from a5a8f93 to c244f00 Compare July 31, 2024 19:54
@ahnpnl ahnpnl marked this pull request as ready for review July 31, 2024 20:13
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 31, 2024 20:13
@ahnpnl
fix: revert support implementation for Node16/NodeNext
bde492d 
- For CJS mode, `module` is always `CommonJS`
- For ESM mode, `module` with value `Node16/NodeNext` will use `ESNext`, otherwise use the value provided by test `tsconfig`
- `moduleResolution` is always `Node10`

Fixes #4468
Fixes #4473
@ahnpnl ahnpnl force-pushed the fix/revert-support-node16-nodenext branch from c244f00 to bde492d Compare July 31, 2024 20:14
@ahnpnl ahnpnl merged commit 70b9530 into main Aug 1, 2024
17 checks passed
@ahnpnl ahnpnl deleted the fix/revert-support-node16-nodenext branch August 1, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ts-jest 29.2 breaks dependency transform [Bug]: Version 29.2.1 breaks default imports
3 participants
@ahnpnl @coveralls @kulshekhar