Skip to content

Commit

Permalink
[rb] implement Remote::Driver as a class not a module
Browse files Browse the repository at this point in the history
  • Loading branch information
titusfortner committed Jun 29, 2017
1 parent 8981d39 commit b700761
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 94 deletions.
2 changes: 0 additions & 2 deletions rb/lib/selenium/webdriver/remote.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
require 'selenium/webdriver/remote/capabilities'
require 'selenium/webdriver/remote/oss/bridge'
require 'selenium/webdriver/remote/oss/commands'
require 'selenium/webdriver/remote/oss/driver'

require 'selenium/webdriver/remote/w3c/bridge'
require 'selenium/webdriver/remote/w3c/capabilities'
require 'selenium/webdriver/remote/w3c/commands'
require 'selenium/webdriver/remote/w3c/driver'
21 changes: 14 additions & 7 deletions rb/lib/selenium/webdriver/remote/driver.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,23 @@ module Remote
# @api private
#

module Driver
class Driver < WebDriver::Driver
include DriverExtensions::UploadsFiles
include DriverExtensions::TakesScreenshot
include DriverExtensions::HasSessionId
include DriverExtensions::Rotatable
include DriverExtensions::HasRemoteStatus
include DriverExtensions::HasWebStorage

def self.new(**opts)
def initialize(opts = {})
listener = opts.delete(:listener)
bridge = Bridge.handshake(opts)
if bridge.dialect == :w3c
W3C::Driver.new(bridge, listener: listener)
else
OSS::Driver.new(bridge, listener: listener)
@bridge = Bridge.handshake(opts)
if @bridge.dialect == :oss
extend DriverExtensions::HasTouchScreen
extend DriverExtensions::HasLocation
extend DriverExtensions::HasNetworkConnection
end
super(@bridge, listener: listener)
end

end # Driver
Expand Down
44 changes: 0 additions & 44 deletions rb/lib/selenium/webdriver/remote/oss/driver.rb

This file was deleted.

41 changes: 0 additions & 41 deletions rb/lib/selenium/webdriver/remote/w3c/driver.rb

This file was deleted.

0 comments on commit b700761

Please sign in to comment.