Skip to content

Commit

Permalink
test: upgrade playwright-chromium from 1.14.1 to 1.17.2
Browse files Browse the repository at this point in the history
This is a prereq for vercel#36490 because the Events Timing API
used to measure Interaction to Next Paint (INP, experiemental web vital)
is only available in Chromium >= v98.
  • Loading branch information
Keen Yee Liau committed Jun 3, 2022
1 parent 401a9a4 commit 0713843
Show file tree
Hide file tree
Showing 5 changed files with 91 additions and 99 deletions.
22 changes: 11 additions & 11 deletions .github/workflows/build_test_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: node run-tests.js --type development
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: node run-tests.js --type development
Expand Down Expand Up @@ -373,7 +373,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: NEXT_TEST_MODE=dev node run-tests.js --type e2e
Expand Down Expand Up @@ -425,7 +425,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: NEXT_TEST_MODE=dev node run-tests.js --type e2e
Expand Down Expand Up @@ -480,7 +480,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: node run-tests.js --type production
Expand Down Expand Up @@ -522,7 +522,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: node run-tests.js --type production
Expand Down Expand Up @@ -567,7 +567,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: NEXT_TEST_MODE=start node run-tests.js --type e2e
Expand Down Expand Up @@ -613,7 +613,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: NEXT_TEST_MODE=start node run-tests.js --type e2e
Expand Down Expand Up @@ -659,7 +659,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: xvfb-run node run-tests.js --timings -g ${{ matrix.group }}/18
Expand Down Expand Up @@ -953,7 +953,7 @@ jobs:
name: next-swc-test-binary
path: packages/next-swc/native

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
name: Install playwright dependencies

- run: RESET_VC_PROJECT=true node scripts/reset-vercel-project.mjs
Expand Down Expand Up @@ -1148,7 +1148,7 @@ jobs:
node-version: 16
check-latest: true

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps
if: ${{needs.build.outputs.docsChange != 'docs only change'}}

- run: node ./scripts/setup-wasm.mjs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test_react_experimental.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ jobs:
path: ./*
key: ${{ github.sha }}-react-experimental

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps

- run: node run-tests.js --timings -g ${{ matrix.group }}/6
2 changes: 1 addition & 1 deletion .github/workflows/test_react_next.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@ jobs:
path: ./*
key: ${{ github.sha }}-react-next

- run: npm i -g playwright-chromium@1.14.1 && npx playwright install-deps
- run: npm i -g playwright-chromium@1.17.2 && npx playwright install-deps

- run: node run-tests.js --timings -g ${{ matrix.group }}/6
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
"npm-run-all": "4.1.5",
"nprogress": "0.2.0",
"pixrem": "5.0.0",
"playwright-chromium": "1.14.1",
"playwright-chromium": "1.17.2",
"plop": "3.0.5",
"postcss-nested": "4.2.1",
"postcss-pseudoelements": "5.0.0",
Expand Down
Loading

0 comments on commit 0713843

Please sign in to comment.