Updated Readme #26
Merged
Updated Readme #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
mfaizanse
added
the
do-not-merge/hold
NHingerl
reviewed
Dec 14, 2023
| ``` | ||
|
|
||
| ## Deployment | ||
|
|
||
| You need a Kubernetes cluster to run against. You can use [k3d](https://k3d.io/) to get a local cluster for testing, or run against a remote cluster. |
There was a problem hiding this comment.
Isn't this already listed in the ## Prerequisites section? Why mention it again here?
There was a problem hiding this comment.
I just followed the pattern from our other repos (example), I can remove it?
There was a problem hiding this comment.
Let's keep consistency for now. In the long term, we can look into removing redundancy in all repos.
friedrichwilken
requested changes
Dec 14, 2023
Co-authored-by: Friedrich <jens.wilken@sap.com> Co-authored-by: Nina Hingerl <76950046+NHingerl@users.noreply.github.com>
friedrichwilken
approved these changes
Dec 14, 2023
NHingerl
approved these changes
Dec 14, 2023
mfaizanse
removed
the
do-not-merge/hold
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)