Refactored makefile #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
mfaizanse
commented
Dec 13, 2023
| @@ -1,30 +1,119 @@ | |||
| APP_NAME = event-publisher-proxy | |||
There was a problem hiding this comment.
This make file is inspired by the makefile of eventing-manager!!!
grischperl
reviewed
Dec 13, 2023
| # Image URL to use all building/pushing image targets | ||
| IMG_REGISTRY_PORT ?= 8888 | ||
| IMG_REGISTRY ?= op-skr-registry.localhost:$(IMG_REGISTRY_PORT)/unsigned/eventing-images | ||
| IMG ?= $(IMG_REGISTRY)/$(APP_NAME):$(APP_VERSION) |
There was a problem hiding this comment.
Is APP_VERSION missing or going to be added later?
There was a problem hiding this comment.
This will come as ENV from build pipeline (i.e. prow), I did not add a default value because we do not have .version file in EPP.
If we had .version file we could have done something like this, but since we are also trying to get rid of .version file in other repositories, so I did not add this file.
There was a problem hiding this comment.
For local dev, we will use the command like make docker-build IMG=mfaizan21/eventing-publisher-proxy:test1 so we do not need APP_VERSION for local development.
| run: go-gen fmt vet ## Run publisher from your host. | ||
| go run ./cmd/event-publisher-proxy/main.go | ||
|
|
||
| .PHONY: release-image |
grischperl
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)