Attempt to kill workers once per request #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change attempts to kill workers once per request. The reason for this is that the
QUIT
signal tells a Unicorn worker to shut down gracefully. Previously,WorkerKiller.kill_self
would send theQUIT
signal, then tell the worker to loop until it died. This loop prevented graceful shutdowns of the worker.My first solution for this was to either fork the process (or use a
Thread
) and callProcess.kill :QUIT, worker_pid
from there, but this solution seems more elegant. In general Unicorn workers are good about gracefully shutting down when they receive aQUIT
(is there significant evidence of them not?), so this solution attempts to send aQUIT
first, and then escalates from there on each following request.It's a somewhat significant change and a version bump, so I thought I'd open it for discussion briefly before merging and releasing.