driver: digitalloggers_restapi: enable REST API #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy HTTP API does not work on newer units without manually changing the configuration in Setup. This driver is based on https://www.digital-loggers.com/restapi.pdf Curl examples that were used for development are included as comments so that users can test their access outside of labgrid. The REST API seems to only allow authenticated users, so the host: parameter is parsed to pass user and password to HTTPDigestAuth. CSRF is also required, so a valid (simple) header is provided. Non-authenticated URLs are supported, but most likely will not work. HTTPS is recommended, but the units ship with self-signed certificates so SSL certificate verification warnings are intentionally ignored. Add to test_powerdriver.py import test. Example usage in lg-env.yaml (default as-shipped settings): NetworkPowerPort: model: 'digitalloggers_restapi' host: 'http://admin:1234@192.168.0.100' index: 0 Signed-off-by: Tim Orling <tim.orling@konsulko.com>
moto-timo
force-pushed
the
digitalloggers_restapi
branch
from
3b6145d
to
b7e9452
Compare
|
Added to test_powerdriver.py in second push. |
Emantor
approved these changes
Oct 1, 2024
|
Have you considered contributing this to pdudaemon? Please see our merge policy for network PDUs: #1031 |
There is no support for digitalloggers in pdudaemon but there was support in labgrid... I'm not currently using pdudaemon and the code will be significantly different so no sure when i will have time for that. I remember conversations about pdudaemon in the past, not opposed to the policy... I almost feel like we should drop network power support in labgrid though to avoid confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy HTTP API does not work on newer units without manually changing the configuration in Setup.
This driver is based on https://www.digital-loggers.com/restapi.pdf
Curl examples that were used for development are included as comments so that users can test their access outside of labgrid.
The REST API seems to only allow authenticated users, so the host: parameter is parsed to pass user and password to HTTPDigestAuth. CSRF is also required, so a valid (simple) header is provided. Non-authenticated URLs are supported, but most likely will not work.
HTTPS is recommended, but the units ship with self-signed certificates so SSL certificate verification warnings are intentionally ignored.
Example usage in lg-env.yaml (default as-shipped settings):
NetworkPowerPort:
model: 'digitalloggers_restapi'
host: 'http://admin:1234@192.168.0.100'
index: 0
Description
Checklist