fix: custom chat title #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Apply Sweep Rules to your PR?
|
c121914yu
reviewed
Dec 1, 2023
| ...(customTitle ? { customTitle } : {}), | ||
| ...(top ? { top } : { top: null }) | ||
| }); | ||
| },{ new: true }); |
There was a problem hiding this comment.
确实，当时为了调试输出用的，是删掉new就通过了？
目前是使用findByIdAndUpdate没正确更新titile，刷新就会重新读取title，使用findOneAndUpdate({ chatId: chatId }这样的方式也不正确吗？
There was a problem hiding this comment.
findOneAndUpdate是正确的，因为chatId是个独立的属性。但是不需要后面的new true，否则有可能创建脏数据。
There was a problem hiding this comment.
确实，当时为了调试输出用的，是删掉new就通过了？
目前是使用findByIdAndUpdate没正确更新titile，刷新就会重新读取title，使用findOneAndUpdate({ chatId: chatId }这样的方式也不正确吗？
可以修改下再push下
c121914yu
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Update Custom Chat Title Based on chatId