fix(serverless): properly remove Cron functions (#1027)

lagonapp · Jul 16, 2023 · 0fb1f28 · 0fb1f28 · vercel · Jul 16, 2023
1 parent 8db1289
commit 0fb1f28
Show file tree

Hide file tree

Showing 3 changed files with 1,559 additions and 2,555 deletions.
diff --git a/.changeset/shiny-plums-yell.md b/.changeset/shiny-plums-yell.md
@@ -0,0 +1,5 @@
+---
+'@lagon/serverless': patch
+---
+
+Properly remove Cron functions
diff --git a/crates/serverless/src/deployments/pubsub.rs b/crates/serverless/src/deployments/pubsub.rs
@@ -143,13 +143,9 @@ where
                         )
                         .await;
 
-                        if deployment.should_run_cron() {
-                            let mut cronjob = cronjob.lock().await;
+                        let mut cronjob = cronjob.lock().await;
 
-                            if let Err(error) = cronjob.remove(&deployment.id).await {
-                                error!(deployment = deployment.id; "Failed to remove cron: {}", error);
-                            }
-                        }
+                        cronjob.remove(&deployment.id).await.unwrap_or(());
                     }
                     Err(error) => {
                         increment_counter!(