[Flink] LakeSoulSinkGlobalCommitter #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ceng23333
commented
Jun 26, 2023
•
Ceng23333
commented
- Add LakeSoulSinkGlobalCommitter and deprecate task-level LakeSoulSinkCommitter
- Infer table creation/schema change directly from data, so that upstream doesn't have to provide DDL event, which simplified CDC sync and enable whole database sink to LakeSoul for any DB
- For CDC Task
- Sink DDL/CreateTable will be handled at LakeSoulSinkGlobalCommitter.commit() instead of SinkFunction or entrypoint of task
- Serializer of Source Record is updated
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: fphantam <dongf@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
…itter Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: zenghua <huazeng@dmetasoul.com>
Signed-off-by: fphantam <dongf@dmetasoul.com>
Signed-off-by: fphantam <dongf@dmetasoul.com>
xuchen-plus
approved these changes
Jun 27, 2023
F-PHantam
added a commit
to F-PHantam/LakeSoul
that referenced
this pull request
Jul 3, 2023
* new class for implementing LakeSoulSinkGlobalCommitter Signed-off-by: zenghua <huazeng@dmetasoul.com> * disable task-level committer and enable globalcommitter Signed-off-by: zenghua <huazeng@dmetasoul.com> * cdc source change Signed-off-by: fphantam <dongf@dmetasoul.com> * update LakeSoulSinkGlobalCommitter && flink-cdc-test.yml Signed-off-by: zenghua <huazeng@dmetasoul.com> * fix flink datatype conversion Signed-off-by: zenghua <huazeng@dmetasoul.com> * fix flink varchar conversion Signed-off-by: zenghua <huazeng@dmetasoul.com> * add field TableSchemaIdentity::isCdc Signed-off-by: zenghua <huazeng@dmetasoul.com> * update LakeSoulSinkGlobalCommitter Signed-off-by: zenghua <huazeng@dmetasoul.com> * fix lakesoul_cdc_change_column handling Signed-off-by: zenghua <huazeng@dmetasoul.com> * fix lakesoul_cdc_change_column handling Signed-off-by: zenghua <huazeng@dmetasoul.com> * merge develop code and format Signed-off-by: fphantam <dongf@dmetasoul.com> * modify test case Signed-off-by: fphantam <dongf@dmetasoul.com> --------- Signed-off-by: zenghua <huazeng@dmetasoul.com> Signed-off-by: fphantam <dongf@dmetasoul.com> Co-authored-by: zenghua <huazeng@dmetasoul.com> Co-authored-by: fphantam <dongf@dmetasoul.com> Signed-off-by: fphantam <dongf@dmetasoul.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.