register / remove metrics of dumpling

lance6716 · Dec 31, 2020 · a91adcb · a91adcb
1 parent 5f55bf3
commit a91adcb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/dumpling/dumpling.go b/dumpling/dumpling.go
@@ -20,6 +20,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/prometheus/client_golang/prometheus"
+
 	"github.com/pingcap/dm/dm/config"
 	"github.com/pingcap/dm/dm/pb"
 	"github.com/pingcap/dm/dm/unit"
@@ -219,6 +221,7 @@ func (m *Dumpling) constructArgs() (*export.Config, error) {
 	dumpConfig.CompleteInsert = true // always keep column name in `INSERT INTO` statements.
 	dumpConfig.Logger = m.logger.Logger
 	dumpConfig.NoViews = false
+	dumpConfig.Labels = prometheus.Labels{"task": cfg.Name}
 
 	if cfg.Threads > 0 {
 		dumpConfig.Threads = cfg.Threads

diff --git a/dumpling/metrics.go b/dumpling/metrics.go
@@ -14,6 +14,7 @@
 package dumpling
 
 import (
+	"github.com/pingcap/dumpling/v4/export"
 	"github.com/prometheus/client_golang/prometheus"
 
 	"github.com/pingcap/dm/pkg/metricsproxy"
@@ -33,8 +34,10 @@ var (
 // RegisterMetrics registers metrics.
 func RegisterMetrics(registry *prometheus.Registry) {
 	registry.MustRegister(dumplingExitWithErrorCounter)
+	export.RegisterMetrics(registry)
 }
 
 func (m *Dumpling) removeLabelValuesWithTaskInMetrics(task string) {
 	dumplingExitWithErrorCounter.DeleteAllAboutLabels(prometheus.Labels{"task": task})
+	export.RemoveLabelValuesWithTaskInMetrics(prometheus.Labels{"task": task})
 }