Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java): enable lance-jni rust release #2369

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

LuQQiu
Copy link
Collaborator

@LuQQiu LuQQiu commented May 22, 2024

Enable the release of lance-jni so that it's utils can be reused by lancedb-jni rust module

@github-actions github-actions bot added the chore label May 22, 2024
@LuQQiu LuQQiu requested a review from QianZhu May 22, 2024 15:15
@wjones127
Copy link
Contributor

Our release process is documented here: https://github.com/lancedb/lance/blob/main/release_process.md

Not sure if this is the appropriate PR, but could we make sure to document the java release as part of that. Also consider whether you want java releases to also do beta/preview ones, or just full ones.

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented May 22, 2024

@wjones127 We are figuring out the java release process, probably do manual release for the first one, and then add it to the automatic action later

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Jun 10, 2024

@QianZhu could we enable lance-jni rust release?
this is only for lancedb-jni rust to reuse the same JNI functions

@QianZhu
Copy link
Contributor

QianZhu commented Jun 11, 2024

@QianZhu could we enable lance-jni rust release? this is only for lancedb-jni rust to reuse the same JNI functions

Do we have to consider the compatibility between the versions of lance-jni and lancedb-jni?

@LuQQiu
Copy link
Collaborator Author

LuQQiu commented Jun 11, 2024

@QianZhu
LanceDB spark catalog service depends on Lance Spark connector
LanceDB lancedb jni depends on lance jni

Ideally it better to be the same version dependencies as LanceDB vs Lance Rust core

@LuQQiu LuQQiu merged commit 848a5db into lancedb:main Jun 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants