Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make IVF_HNSW_SQ work with dot distance #2472

Merged
merged 4 commits into from
Jun 15, 2024
Merged

feat: make IVF_HNSW_SQ work with dot distance #2472

merged 4 commits into from
Jun 15, 2024

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 14, 2024

  • Make SQ storage work with Dot distance
  • Add test for IVF_HNSW_SQ + Dot

@github-actions github-actions bot added the enhancement New feature or request label Jun 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.02%. Comparing base (bf6b104) to head (9b1987e).
Report is 2 commits behind head on main.

Files Patch % Lines
rust/lance-index/src/vector/sq/storage.rs 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
+ Coverage   80.01%   80.02%   +0.01%     
==========================================
  Files         207      207              
  Lines       58735    58753      +18     
  Branches    58735    58753      +18     
==========================================
+ Hits        46997    47020      +23     
- Misses       8984     8985       +1     
+ Partials     2754     2748       -6     
Flag Coverage Δ
unittests 80.02% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddyxu eddyxu merged commit 9c536b9 into main Jun 15, 2024
18 of 19 checks passed
@eddyxu eddyxu deleted the lei/hnsw_dot branch June 15, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants