Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow row id only in v2 #2481

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

westonpace
Copy link
Contributor

Closes #2480

@github-actions github-actions bot added the bug Something isn't working label Jun 17, 2024
@westonpace
Copy link
Contributor Author

Rebased and will merge on green

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (7cd11b8) to head (6b31be5).

Files Patch % Lines
rust/lance/src/dataset/fragment.rs 45.16% 5 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2481      +/-   ##
==========================================
- Coverage   79.55%   79.46%   -0.10%     
==========================================
  Files         208      208              
  Lines       59351    58957     -394     
  Branches    59351    58957     -394     
==========================================
- Hits        47217    46848     -369     
+ Misses       9371     9368       -3     
+ Partials     2763     2741      -22     
Flag Coverage Δ
unittests 79.46% <56.41%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit e4122a6 into lancedb:main Jun 24, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read "just the row id" from a dataset using v2 files
3 participants