Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable aarch64-pc-windows builds #2512

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

NickDarvey
Copy link
Contributor

Minimally enables aarch64-pc-windows by always returning false for NEON FP16 support checks.

Minimally enables `aarch64-pc-windows` by always returning false for NEON FP16 support checks.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.56%. Comparing base (0bf765b) to head (46d0090).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2512   +/-   ##
=======================================
  Coverage   79.55%   79.56%           
=======================================
  Files         208      208           
  Lines       59348    59348           
  Branches    59348    59348           
=======================================
+ Hits        47216    47220    +4     
  Misses       9371     9371           
+ Partials     2761     2757    -4     
Flag Coverage Δ
unittests 79.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 changed the title chore: enable aarch64-pc-windows builds feat: enable aarch64-pc-windows builds Jun 24, 2024
@wjones127 wjones127 removed the chore label Jun 24, 2024
@github-actions github-actions bot added the enhancement New feature or request label Jun 24, 2024
@wjones127 wjones127 merged commit 1ee75d3 into lancedb:main Jun 24, 2024
22 checks passed
@wjones127
Copy link
Contributor

Thanks @NickDarvey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants