Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to create v2 fragments using the fragment API #2534

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

westonpace
Copy link
Contributor

Previously it was ignoring the use_legacy_format option

@github-actions github-actions bot added enhancement New feature or request python labels Jun 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 84.21053% with 9 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (63227f4) to head (9869ffc).

Files Patch % Lines
rust/lance/src/dataset/fragment/write.rs 84.21% 0 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   79.76%   79.77%           
=======================================
  Files         207      207           
  Lines       59586    59643   +57     
  Branches    59586    59643   +57     
=======================================
+ Hits        47528    47578   +50     
+ Misses       9264     9257    -7     
- Partials     2794     2808   +14     
Flag Coverage Δ
unittests 79.77% <84.21%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit cda801b into lancedb:main Jun 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants