-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: flat search to use datafusion top k #2535
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
==========================================
- Coverage 79.80% 79.78% -0.02%
==========================================
Files 207 207
Lines 59636 59569 -67
Branches 59636 59569 -67
==========================================
- Hits 47591 47529 -62
+ Misses 9261 9254 -7
- Partials 2784 2786 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rust/lance-index/src/vector/flat.rs
Outdated
@@ -34,56 +23,19 @@ fn distance_field() -> ArrowField { | |||
|
|||
#[instrument(level = "debug", skip_all)] | |||
pub async fn flat_search( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: this method name doesn't match what it does since this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed.
a13f81b
to
a153905
Compare
Closes #1324