feat: add fragments option to the scanner itself #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyxu
reviewed
May 18, 2023
python/python/lance/dataset.py
Outdated
| if isinstance(f, LanceFragment): | ||
| inner_fragments.append(f._fragment) | ||
| else: | ||
| raise TypeError("fragments must be an iterable of LanceFragment") |
There was a problem hiding this comment.
Could you also add a message to tell user what the current type of f is , for easy debugging?
python/python/lance/dataset.py
Outdated
| # TODO: can we take kwargs here for the scanner builder? | ||
| # TODO: peek instead of list | ||
| warnings.warn( | ||
| "Deprecated in version 0.4.13. Use the fragments argument in LanceDataset.scanner() instead.", |
There was a problem hiding this comment.
we might only have 1-2 users are using this method. Let's make sure they know, and we can delete this method in a few versions later?
There was a problem hiding this comment.
Actually this method is semi-private method, right? so users dont directly use it, instead they use Dataset.scanner(fragments=...)?
There was a problem hiding this comment.
Dataset.scanner(fragments=...) doesn't use this function, so if no one is using from_fragments() we can delete it.
eddyxu
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support setting other scanner options along with the fragments, add
fragmentsas an argument in the scanner itself.