Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] Allow recreate index with the same name on the same column #929

Merged
merged 6 commits into from
Jun 1, 2023
Merged

[Rust] Allow recreate index with the same name on the same column #929

merged 6 commits into from
Jun 1, 2023

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Jun 1, 2023

@eddyxu
Copy link
Contributor Author

eddyxu commented Jun 1, 2023

Windows failure seems to be due to vcpkg outage and it is irrelevant,

@chebbyChefNEQ
Copy link
Contributor

chebbyChefNEQ commented Jun 1, 2023 •
edited
Loading

nit: maybe there should be a flag? replace=True.

Rationale being that some callers may want behaviors like CREATE IF NOT EXISTS instead of replace be default. I guess this behavior can be added on the lancedb side.

@eddyxu
Copy link
Contributor Author

eddyxu commented Jun 1, 2023

nit: maybe there should be a flag? replace=True.

Rationale being that some callers may want behaviors like CREATE IF NOT EXISTS instead of replace be default. I guess this behavior can be added on the lancedb side.

Makes sense.

@eddyxu eddyxu merged commit eb597bb into main Jun 1, 2023
@eddyxu eddyxu deleted the lei/reindex branch June 1, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chebbyChefNEQ chebbyChefNEQ chebbyChefNEQ approved these changes

@changhiskhan changhiskhan Awaiting requested review from changhiskhan

@wjones127 wjones127 Awaiting requested review from wjones127

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to create index again with the same index name
2 participants
@eddyxu @chebbyChefNEQ