Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Mariadb version based on pantheon.yml file #16

Closed
dustinleblanc opened this issue Jul 30, 2021 · 0 comments · Fixed by #17
Closed

Set Mariadb version based on pantheon.yml file #16

dustinleblanc opened this issue Jul 30, 2021 · 0 comments · Fixed by #17
Assignees
@dustinleblanc
Labels
enhancement New feature or request pantheon

Comments

@dustinleblanc
Copy link
Collaborator

It looks like Pantheon has begun specifying the Mariadb version in the pantheon.upstream.yml, which doesn't match our pre-emptive method for configuring this.
image

cli/integrations/lando-pantheon/recipes/pantheon/builder.js

Line 110 in af1a185

options.database = (options.framework === 'drupal9') ? 'mariadb:10.4': 'mariadb:10.1';

We should swap this to just straight up use the config value from the pantheon.yml
@dustinleblanc dustinleblanc added enhancement New feature or request pantheon labels Jul 30, 2021
@dustinleblanc dustinleblanc self-assigned this Jul 30, 2021
dustinleblanc added a commit that referenced this issue Jul 30, 2021
@dustinleblanc
Fixes #16: Set the MariaDB version from pantheon.yml
45dc73b
@pirog pirog closed this as completed in d3c4985 Aug 23, 2021
@pirog pirog linked a pull request Aug 23, 2021 that will close this issue
Fixes #16: Set the MariaDB version from pantheon.yml #17
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dustinleblanc dustinleblanc

Labels
enhancement New feature or request pantheon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #16: Set the MariaDB version from pantheon.yml lando/cli
1 participant
@dustinleblanc