Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: doc string of default params in chat_models, llm qianfan #12153

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: doc string of default params in chat_models, llm qianfan #12153

merged 1 commit into from
Oct 23, 2023

Conversation

danielhjz
Copy link
Contributor

  • Description: a fix of the doc string in Qianfan
  • Issue: no
  • Dependencies: no
  • Tag maintainer: @baskaryan
  • Twitter handle: no

@vercel
Copy link

vercel bot commented Oct 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2023 10:44am

@dosubot dosubot bot added Ɑ: models Related to LLMs or chat model modules 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Oct 23, 2023
@danielhjz
Copy link
Contributor Author

A simple fix for comment. @cloudscool @@baskaryan PTAL

leo-gan
leo-gan approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@leo-gan leo-gan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leo-gan leo-gan added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 23, 2023
@eyurtsev eyurtsev merged commit 4d6243f into langchain-ai:master Oct 23, 2023
31 checks passed
hoanq1811 pushed a commit to hoanq1811/langchain that referenced this pull request Feb 2, 2024
@danielhjz
fix: doc string of default params in chat_models, llm qianfan (langch…
d6ef410 
…ain-ai#12153)

- **Description:** a fix of the doc string in Qianfan
  - **Issue:** no
  - **Dependencies:** no
  - **Tag maintainer:** @baskaryan
  - **Twitter handle:** no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leo-gan leo-gan leo-gan approved these changes

Assignees
No one assigned
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: models Related to LLMs or chat model modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhjz @leo-gan @eyurtsev