community: Implement lazy_load() for JSONLoader #18643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
eyurtsev
reviewed
Mar 6, 2024
| """Load and return documents from the JSON file.""" | ||
| docs: List[Document] = [] | ||
| index = 0 |
There was a problem hiding this comment.
Having trouble to follow the logic here -- it looks like it's possible for multiple documents to be associated with the same seq_num do you know if this is the desired/correct behavior?
There was a problem hiding this comment.
2 docs shouldn't have the same seq_num.
The index from which the seq_num is started is incremented at each doc that is yielded so it should be good.
The test https://github.com/langchain-ai/langchain/blob/master/libs/community/tests/unit_tests/document_loaders/test_json_loader.py#L179 normally validates that it works.
Are you seeing something that is wrong ?
eyurtsev
approved these changes
Mar 8, 2024
dosubot
bot
added
the
lgtm
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
Covered by `tests/unit_tests/document_loaders/test_json_loader.py`
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
Covered by `tests/unit_tests/document_loaders/test_json_loader.py`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covered by
tests/unit_tests/document_loaders/test_json_loader.py