elasticsearch: check for deployed models #18973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
joemcelroy
approved these changes
Mar 12, 2024
5 tasks
gkorland
pushed a commit
to FalkorDB/langchain
that referenced
this pull request
Mar 30, 2024
When creating a new index, if we use a retrieval strategy that expects a model to be deployed in Elasticsearch, check if a model with this name is indeed deployed before creating an index. This lowers the probability to get into a state in which an index was created with a faulty model ID, which cannot be overwritten any more (the index has to manually be deleted).
chrispy-snps
pushed a commit
to chrispy-snps/langchain
that referenced
this pull request
Mar 30, 2024
When creating a new index, if we use a retrieval strategy that expects a model to be deployed in Elasticsearch, check if a model with this name is indeed deployed before creating an index. This lowers the probability to get into a state in which an index was created with a faulty model ID, which cannot be overwritten any more (the index has to manually be deleted).
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
When creating a new index, if we use a retrieval strategy that expects a model to be deployed in Elasticsearch, check if a model with this name is indeed deployed before creating an index. This lowers the probability to get into a state in which an index was created with a faulty model ID, which cannot be overwritten any more (the index has to manually be deleted).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new index, if we use a retrieval strategy that expects a model to be deployed in Elasticsearch, check if a model with this name is indeed deployed before creating an index. This lowers the probability to get into a state in which an index was created with a faulty model ID, which cannot be overwritten any more (the index has to manually be deleted).