Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community: Fix bug in vdms #19728

Merged
merged 3 commits into from
Mar 28, 2024
Merged

community: Fix bug in vdms #19728

merged 3 commits into from
Mar 28, 2024

Conversation

cwlacewe
Copy link
Contributor

Description: Fix embedding check in vdms
Contribution maintainer: @cwlacewe

@vercel Vercel
Copy link

vercel bot commented Mar 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 7:41pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Mar 28, 2024
@ccurme
Copy link
Collaborator

ccurme commented Mar 28, 2024

Could you comment on why an empty bytes is preferable to None? Thanks.

@cwlacewe
Copy link
Contributor Author

cwlacewe commented Mar 28, 2024 •
edited
Loading

Could you comment on why an empty bytes is preferable to None? Thanks.

@ccurme,
Internally VDMS expects an empty array if no blob/bytes data is provided. In the case of the VDMS integration, no data is considered None so we provide checks and only update array for VDMS query if data is provided.

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 28, 2024
@baskaryan baskaryan merged commit 4a49fc5 into langchain-ai:master Mar 28, 2024
59 checks passed
@cwlacewe cwlacewe deleted the bug-fix branch March 30, 2024 03:28
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@cwlacewe @gkorland
community[patch]: Fix bug in vdms (langchain-ai#19728)
f5ceb0d 
**Description:** Fix embedding check in vdms
**Contribution maintainer:** [@cwlacewe](https://github.com/cwlacewe)
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@cwlacewe @hinthornw
community[patch]: Fix bug in vdms (#19728)
539a4b0 
**Description:** Fix embedding check in vdms
**Contribution maintainer:** [@cwlacewe](https://github.com/cwlacewe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baskaryan baskaryan baskaryan approved these changes

Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwlacewe @ccurme @baskaryan