Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: Vectara Integration Update - Streaming, FCS, Chat, updates to documentation and example notebooks #21334

Merged
merged 43 commits into from
Jun 4, 2024

Conversation

ofermend
Copy link
Contributor

@ofermend ofermend commented May 6, 2024

Thank you for contributing to LangChain!

Description: update to the Vectara / Langchain integration to integrate new Vectara capabilities:

  • Full RAG implemented as a Runnable with as_rag()
  • Vectara chat supported with as_chat()
  • Both support streaming response
  • Updated documentation and example notebook to reflect all the changes
  • Updated Vectara templates

Twitter handle: ofermend

Add tests and docs: no new tests or docs, but updated both existing tests and existing docs

1. Updated the code to support streaming, changed VectaraRetriever and added VectaraRAG accordingly
2. Updated all example notebooks, including updates to FCS, streaming
3. Updated documentation
4. Updates and re-validation of regression tests
Fixed Vectara templates
@efriis efriis added the template label May 6, 2024
@efriis efriis self-assigned this May 6, 2024
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 2:45am

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🤖:improvement Medium size change to existing code to handle new use-cases labels May 6, 2024
@ofermend ofermend changed the title community: Vectara 2024 Update - Streaming, FCS, Chat, updates to documentation and example notebooks community: Vectara Integration Update - Streaming, FCS, Chat, updates to documentation and example notebooks May 6, 2024
@ofermend
Copy link
Contributor Author

ofermend commented May 9, 2024

Hey @efriis and @baskaryan - just checking about your thoughts on this PR?

Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to just implement this as a vectara_v2 retriever instead? There's a few breaking changes in here that will cause issues if anyone is using this currently.

Also - am I correct in my understanding that this only implements streaming for the generic VectaraRAG Runnable and not for a retriever?

Added unit testing for backwards compatibility
Retested IPYNB notebooks
@ofermend
Copy link
Contributor Author

Thanks @efriis for all the great comments and suggestions to making this backwards compatible.
I did a lot of work to make it so today, including adding tests for the same. Please review and let me know if I missed any other point there.
I don't think we need this to be retriever_v2 as these changes address backwards compatibility, but please let me know if you think otherwise.

And yes streaming is only for VectaraRAG. I am unsure how streaming from Vectara could/should work for the retriever alone (which just acts as semantic search) - did you have anything specific in mind here?

@damianoneill
Copy link

@ofermend, thank you for this PR looking forward to using these updates, glad to see that you made these changes backwards compatible.

@efriis is there anything additional required in this PR? Apologies, I'm not familiar with the merge process/release schedule, just looking to understand when this would be available in a release?

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 4, 2024
@baskaryan baskaryan merged commit ad502e8 into langchain-ai:master Jun 4, 2024
44 checks passed
hinthornw pushed a commit that referenced this pull request Jun 20, 2024
…updates to documentation and example notebooks (#21334)

Thank you for contributing to LangChain!

**Description:** update to the Vectara / Langchain integration to
integrate new Vectara capabilities:
- Full RAG implemented as a Runnable with as_rag()
- Vectara chat supported with as_chat()
- Both support streaming response
- Updated documentation and example notebook to reflect all the changes
- Updated Vectara templates

**Twitter handle:** ofermend

**Add tests and docs**: no new tests or docs, but updated both existing
tests and existing docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XXL This PR changes 1000+ lines, ignoring generated files. template Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants