Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: model parameter mandatory for cohere embedding and rerank #23349

Merged
merged 7 commits into from
Jul 12, 2024
Merged

docs: model parameter mandatory for cohere embedding and rerank #23349

merged 7 commits into from
Jul 12, 2024

Conversation

Anirudh31415926535
Copy link
Contributor

@Anirudh31415926535 Anirudh31415926535 commented Jun 24, 2024 •
edited
Loading

Latest langchain-cohere sdk mandates passing in the model parameter into the Embeddings and Reranker inits.

This PR is to update the docs to reflect these changes.

@efriis efriis self-assigned this Jun 24, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 11:07pm

@Anirudh31415926535 Anirudh31415926535 marked this pull request as ready for review June 24, 2024 09:30
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community Ɑ: embeddings Related to text embedding models module Ɑ: retriever Related to retriever module 🔌: cohere Primarily related to Cohere integrations 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jun 24, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 24, 2024
@ccurme ccurme enabled auto-merge (squash) June 24, 2024 20:03
auto-merge was automatically disabled June 26, 2024 10:20

Head branch was pushed to by a user without write access

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 26, 2024
@ccurme ccurme enabled auto-merge (squash) June 27, 2024 17:24
auto-merge was automatically disabled June 28, 2024 14:19

Head branch was pushed to by a user without write access

@ccurme ccurme enabled auto-merge (squash) July 1, 2024 15:50
@efriis
Copy link
Member

efriis commented Jul 8, 2024

seems to be an issue with snapshots - can take a look this week

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 12, 2024
@ccurme ccurme merged commit 7677cee into langchain-ai:master Jul 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efriis efriis efriis approved these changes

@ccurme ccurme ccurme approved these changes

@billytrend-cohere billytrend-cohere billytrend-cohere approved these changes

Assignees

@efriis efriis

Labels
🔌: cohere Primarily related to Cohere integrations community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder Ɑ: embeddings Related to text embedding models module lgtm PR looks good. Use to confirm that a PR is ready for merging. Ɑ: retriever Related to retriever module size:S This PR changes 10-29 lines, ignoring generated files. template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anirudh31415926535 @efriis @ccurme @billytrend-cohere