Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1468): MemoryVectorStore serialization #1560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jca41
Copy link

@jca41 jca41 commented Jun 6, 2023

Fixes #1468.

Let me know if approach is correct. I can add docs after it gets an initial review.

@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jul 17, 2023 8:36am

@jacoblee93
Copy link
Collaborator

CC @nfcampos

@jacoblee93 jacoblee93 requested a review from nfcampos June 6, 2023 22:29
@jca41
Copy link
Author

jca41 commented Jun 6, 2023

Will also test on a local project to verify it's working correctly

@Joshua-Shepherd
Copy link

@jca41
Sorry to tag you, But I just wanted to ping on this and see if you we're able to confirm everything was functioning correctly, also I don't want this change to fall through the cracks XD

@jca41
Copy link
Author

jca41 commented Jun 19, 2023

@jca41

Sorry to tag you, But I just wanted to ping on this and see if you we're able to confirm everything was functioning correctly, also I don't want this change to fall through the cracks XD

I haven't tested it unfortunately, sorry!

@glorat
Copy link
Contributor

glorat commented Jul 16, 2023

As a passer-by... it looks good to me. I would welcome this as I also have the requirement serialise the memory store

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to serialize MemoryVectorStore correctly?
4 participants