Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename lastStep to previousStep #2759

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

crazywoola
Copy link
Member

@crazywoola crazywoola commented Mar 8, 2024

Description

Rename lastStep to previousStep

Fixes #2750

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@crazywoola crazywoola requested a review from iamjoel March 8, 2024 11:06
@crazywoola crazywoola linked an issue Mar 8, 2024 that may be closed by this pull request
3 tasks
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 8, 2024
@crazywoola crazywoola changed the title Chore/2750 use last step in add knowledge chore: rename lastStep to previousStep Mar 8, 2024
@dosubot dosubot bot added the lgtm label Mar 8, 2024
@crazywoola crazywoola merged commit bbc0d33 into main Mar 8, 2024
10 checks passed
@crazywoola crazywoola deleted the chore/2750-use-last-step-in-add-knowledge branch March 8, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use 'Last step' in Add knowledge is bad choice
2 participants