Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add storage type and Google Storage settings to worker #4266

Conversation

KiyotakaMatsushita
Copy link
Contributor

@KiyotakaMatsushita KiyotakaMatsushita commented May 10, 2024

Description

This change adds support for using Google Cloud Storage as the storage backend for user files in Dify. It introduces two new environment variables for configuring Google Storage: GOOGLE_STORAGE_BUCKET_NAME and GOOGLE_STORAGE_SERVICE_ACCOUNT_JSON_BASE64. When STORAGE_TYPE is set to google-storage, these variables will be used to connect to and store files in a Google Storage bucket.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

  • Tested setting STORAGE_TYPE=google-storage and providing valid values for GOOGLE_STORAGE_BUCKET_NAME and GOOGLE_STORAGE_SERVICE_ACCOUNT_JSON_BASE64
  • Verified user files are successfully stored in and retrieved from the configured Google Storage bucket
  • Ensured existing storage backends (local, S3, Azure Blob) continue to function as expected

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request 📚 documentation Improvements or additions to documentation labels May 10, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 10, 2024
@JohnJyong JohnJyong merged commit 2849527 into langgenius:main May 10, 2024
7 checks passed
@takatost takatost mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation 💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants