Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.yaml #4288

Merged
merged 1 commit into from
May 11, 2024
Merged

Update docker-compose.yaml #4288

merged 1 commit into from
May 11, 2024

Conversation

rechardwang
Copy link
Contributor

It is recommended to include the Email-related ENV configurations in the worker as well, otherwise the worker cannot access the necessary variables for sending emails when executing the email action. Having these SMTP configurations set only in the API is ineffective. Additionally, the CONSOLE_WEB_URL should also be set in the worker's ENV to ensure that the login URL in the emails received by users is correct.

Description

After deploying according to the official documentation, emails cannot be sent.
After reviewing the source code, it was discovered that the email sending function is executed only within the worker. Therefore, the email variables need to be added to the worker's ENV.

It is recommended to include the Email-related ENV configurations in the worker as well, otherwise the worker cannot access the necessary variables for sending emails when executing the email action. Having these SMTP configurations set only in the API is ineffective. Additionally, the CONSOLE_WEB_URL should also be set in the worker's ENV to ensure that the login URL in the emails received by users is correct.
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 11, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely right, thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 11, 2024
@takatost takatost merged commit 198d6c0 into langgenius:main May 11, 2024
7 checks passed
@rechardwang rechardwang deleted the patch-1 branch May 11, 2024 09:00
zxhlyh pushed a commit that referenced this pull request May 13, 2024
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants