Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add zhipu glm_4_plus and glm_4v_plus model #7824

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

hjlarry
Copy link
Contributor

@hjlarry hjlarry commented Aug 30, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Fixes #7822

these two models released yesterday and the offical document has not update yet, currently not clear sure the params of the model, just test it works.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

ed9eb59ea3ab2da7274bac5541ed6df

  • Test A
  • Test B

@hjlarry hjlarry marked this pull request as ready for review August 30, 2024 02:21
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ⚙️ feat:model-runtime labels Aug 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 30, 2024
@crazywoola crazywoola merged commit dc015c3 into langgenius:main Aug 30, 2024
6 checks passed
cuiks pushed a commit to cuiks/dify that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly added large models glm-4-plus and glm-4v-plus
2 participants