-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function naming scheme: _tp_
#152
Comments
I don't feel strong about the specific name; mc seems like a good alternative to tp. So going forward, the convention is that any constraint that does not take the conductor id as an argument, should start with constraint_mc (or alternative to mc)? |
I agree it is good to revisit these constraint names given the package name update. Given our discussion last week I think We would need to get into the details to understand the best software design, but a simple replacement of |
I think it might be a good idea as well to use something like
For now I will use mc everywhere. |
Hello, |
@MartaVanin this is definitely a good point, and ultimately we hope to correct this issue, see #81 and #61 |
This refactor ensures that all variable and constraint functions internal to PowerModelsDistribution, e.g. those containing `_mc_`, have any loops over the phases internal to that function, instead of requiring an explicit loop inside the problem definition. Updates changelog Closes #81 Closes #61 Closes #152
This refactor ensures that all variable and constraint functions internal to PowerModelsDistribution, e.g. those containing `_mc_`, have any loops over the phases internal to that function, instead of requiring an explicit loop inside the problem definition. Updates changelog Closes #81 Closes #61 Closes #152
This refactor ensures that all variable and constraint functions internal to PowerModelsDistribution, e.g. those containing `_mc_`, have any loops over the phases internal to that function, instead of requiring an explicit loop inside the problem definition. Updates changelog Closes #81 Closes #61 Closes #152
Currently, all PowerModelsDistribution variables/constraints/etc. start with e.g.
constraint_tp_
, but with the package rename and move to using theconductor
name convention in PowerModels, I am not suretp
continues to make sense, especially for the run functions with which most users will actually interact.I am inclined to use
mc
for multiconductor, but am open to suggestions, discussion.@ccoffrin @frederikgeth @sanderclaeys
The text was updated successfully, but these errors were encountered: