Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

%rs default value #157

Closed
sanderclaeys opened this issue Aug 20, 2019 · 1 comment
Closed

%rs default value #157

sanderclaeys opened this issue Aug 20, 2019 · 1 comment
Assignees
@pseudocubic
Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Milestone
Release v0.6.0

Comments

@sanderclaeys
Copy link
Contributor

@pseudocubic

The default value for the transformer resistance (%r) is 0.2 (see here). When not specifying this parameter explicitly, I was getting values different from OpenDSS. So I suspect that this default value is not implemented correctly in the parser.
@pseudocubic pseudocubic self-assigned this Aug 21, 2019
@sanderclaeys
Copy link
Contributor Author

The cause for the different values was that the IEEE cases specify the LoadLoss property instead of %rs/%r, which is currently not handled by the parser.

The reason I did not implement this, is that _create_transformer always passes values for both %rs and %loadloss, which can be mutually inconsistent. Consider the lines below
"%loadloss" => get(kwargs, Symbol("%loadloss"), 2.0 * temp["%rs"][1] * 100.0), # CHECK:
"%rs" => get(kwargs, Symbol("%rs"), fill(0.0, windings)),

Two things should change

  1. The default for %rs should not be zero, but the correct default.
  2. The value for %rs should be consistent with %loadloss (overwritten if specified?), in the same way as OpenDSS would do.

pseudocubic added a commit that referenced this issue Aug 28, 2019
@pseudocubic
FIX: OpenDSS transformer %rs and %loadloss handling
118a9c3 
Fixes the handling of `%rs` and `%loadloss` properties on OpenDSS transformers.

For 3-winding transformers:
`%loadloss = sum(%rs[1:2])`
`%rs = [%loadloss/2, %loadloss/2, 0.2]`

For 2-winding transformers, `%rs = fill(%loadloss / 2, 2)

The default value `%r = 0.2` is corrected (was 0.0)

Because the of the new default values, the number of star buses created for 3-winding transformers changes.

Changelog and Unit tests updated

Closes #157
@pseudocubic pseudocubic mentioned this issue Aug 28, 2019
Merged
pseudocubic added a commit that referenced this issue Aug 29, 2019
@pseudocubic
FIX: OpenDSS transformer %rs and %loadloss handling
9079d99 
Fixes the handling of `%rs` and `%loadloss` properties on OpenDSS transformers.

For 3-winding transformers:
`%loadloss = sum(%rs[1:2])`
`%rs = [%loadloss/2, %loadloss/2, 0.2]`

For 2-winding transformers, `%rs = fill(%loadloss / 2, 2)The default value `%r = 0.2` is corrected (was 0.0)

Because the of the new default values, the number of star buses created for 3-winding transformers changes.

Changelog and Unit tests updated

Closes #157
pseudocubic added a commit that referenced this issue Aug 29, 2019
@pseudocubic
FIX: OpenDSS transformer %rs and %loadloss handling (#162)
0736af5 
Fixes the handling of `%rs` and `%loadloss` properties on OpenDSS transformers.

For 3-winding transformers:
`%loadloss = sum(%rs[1:2])`
`%rs = [%loadloss/2, %loadloss/2, 0.2]`

For 2-winding transformers, `%rs = fill(%loadloss / 2, 2)The default value `%r = 0.2` is corrected (was 0.0)

Because the of the new default values, the number of star buses created for 3-winding transformers changes.

Changelog and Unit tests updated

Closes #157
@pseudocubic pseudocubic added this to the Release v0.6.0 milestone Sep 4, 2019
@pseudocubic pseudocubic added Type: Bug Something isn't working Category: Data Parsers parser issues labels Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pseudocubic pseudocubic

Labels
Category: Data Parsers parser issues Type: Bug Something isn't working
Projects
None yet
Milestone
Release v0.6.0
Development

No branches or pull requests
2 participants
@pseudocubic @sanderclaeys