Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] fix BigDecimal creation with blank value on HasAttributes.php #51996

Closed
wants to merge 3 commits into from

Conversation

dukmaurice
Copy link

Issue

Currently you can't cast attribute of decimal type with an empty string

// Return Illuminate\Support\Exceptions\MathException: Unable to cast value to a decimal.
BigDecimal::of(" ")->toScale($decimals, RoundingMode::HALF_UP);

Proposal

I propose to check value passed for BigDecimal creation for prevent MathException

// Before
BigDecimal::of($value)->toScale($decimals, RoundingMode::HALF_UP);

// After
BigDecimal::of(blank($value) ? 0 : $value)->toScale($decimals, RoundingMode::HALF_UP);

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants