Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] fix: findOr and firstOr generics #52037

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Jul 5, 2024

Hello!

This fixes a few issues in the firstOr/findOr method generics---it can't have a null return type because a callback is always expected.

Thanks!

@taylorotwell taylorotwell merged commit af1298c into laravel:11.x Jul 5, 2024
30 checks passed
@calebdw
Copy link
Contributor Author

calebdw commented Jul 5, 2024

Thank you!

@calebdw calebdw deleted the relation_generics branch July 5, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants